BRP on Foundrty VTT - Beta Release

[errains]

Moving my BRP game into Foundry and I seem to be stuck at a Basic point...When creating a character as a DM I can't enter any numbers under the CHAR tab Stats. Also under the portrait the new character starts out as "Dead/Diying"  I'm sure its something easy, but what I'm I miss that will allow me to enter the stats?  

Thanks in advance

[Dangermouse]

1 hour ago, errains said:

Moving my BRP game into Foundry and I seem to be stuck at a Basic point...When creating a character as a DM I can't enter any numbers under the CHAR tab Stats. Also under the portrait the new character starts out as "Dead/Diying"  I'm sure its something easy, but what I'm I miss that will allow me to enter the stats?  

Thanks in advance

Heya. I’m away on holiday until start Sept so don’t have access to my PC. There are some instructions in the game or on the GitHub wiki

https://github.com/Genii-Locorum/brp

 

if that doesn’t solve it please come back and I’ll see what I can do from memory. 
 

initial thoughts are whether the character sheet is locked (padlock icon at the right hand side of the tab names). 
 

are you getting any error messages in console (F12)?

 

sorry that this isn’t as comprehensive response that I’d like to give

 

cheers

 

simon

[JoshB]

Hey all, just started using this module and it is great! Thank you for the hard work. I'm a little confused as to what "Skill Groups" are in Foundry and precisely how to use them.
I might be way off here, but I figured "Any Melee Weapon" was a way of consolidating all the melee weapon skills?

At any rate, when I use any of the group skills I get a warning that says "You cannot add a Group Skill to the sheet"

Thanks in advance!
-Josh

[Dangermouse]

3 hours ago, JoshB said:

Hey all, just started using this module and it is great! Thank you for the hard work. I'm a little confused as to what "Skill Groups" are in Foundry and precisely how to use them.
I might be way off here, but I figured "Any Melee Weapon" was a way of consolidating all the melee weapon skills?

At any rate, when I use any of the group skills I get a warning that says "You cannot add a Group Skill to the sheet"

Thanks in advance!
-Josh

Hi

 

Skill Groups aren’t a core foundry thing per se. For BRP they are a group of skills that get added to a profession. When you add the profession to the character you add one (or more) of the relevant skills in the group. For example a profession may let you choose any melee weapon so there’s a skill group for that. 
 

to add multiple skills to a character sheet you can drag the folder to the character.

 

i hope that makes sense. I’m away from home at the moment so can’t give you screenshots to help with the explanation. 
 

cheers

[BlackLaird]

Hi Dangermouse,

 I hope you are keeping well.

 I am wondering if I can put in a feature request for Personality Traits when you next pick this one up. If this is possible, my personal preference would be for user defined trait pairs rather than pre-set (as per Pendragon for example). 

 Many thanks for your continued efforts and attention - this is fast becoming my favourite system on account of its flexibility and the sterling work you'e put into it to date!

[Dangermouse]

11 minutes ago, BlackLaird said:

Hi Dangermouse,

 I hope you are keeping well.

 I am wondering if I can put in a feature request for Personality Traits when you next pick this one up. If this is possible, my personal preference would be for user defined trait pairs rather than pre-set (as per Pendragon for example). 

 Many thanks for your continued efforts and attention - this is fast becoming my favourite system on account of its flexibility and the sterling work you'e put into it to date!

Of course you can.  I've added it as an issue over on Github Add Personality Traits · Issue #18 · Genii-Locorum/brp (github.com) and pushed it to the top of the project list.

I know I've done very little of late (holiday and then lack of ooompphh).  I will try and tackle this sooner rather than later, but please do chase me on it (I get distracted by other...... ohh look a new Nanowar song...............)

Cheers

SImon

[FantasticSkoph]

Hello!

First off, thank you very much for taking the time and care to make this system on Foundry. I've been aching for something that isn't Cthulhu but also provides somewhat the same gameplay. I seem to have encountered an issue, and I don't know if it's me being a bit dense or if my version of the brp doesn't allow dropping weapons in character sheets.

I have tried going to the compendium and drag and drop for example a rifle. It doesn't appear in either "Combat" or "Items". Some of my characters have the "rifle" skill but no matter what we try, it doesn't seem to want to slide onto the sheet. We also tried to import it into the "items" menu of Foundry, and from there drag and drop it into the sheet, but it shows an error.

"Please assign a combat skill to this weapon before adding it to a character."

When I try to add a "skill option", the scrolling list is blank.

If the issue has already been brought up, then I'm sorry I didn't see the message talking about it.

When I open the console, here's the message I get when I try to add a weapon to the sheet:

actor-itemDrop.mjs:56 Uncaught (in promise) TypeError: Cannot read properties of undefined (reading 'name') at BRPactorItemDrop._BRPonDropItemCreate (actor-itemDrop.mjs:56:61) at BRPCharacterSheet._onDropItemCreate (character.mjs:445:48) at BRPCharacterSheet._onDropItem (foundry.js:75007:17)

	_BRPonDropItemCreate	@	actor-itemDrop.mjs:56
	_onDropItemCreate	@	character.mjs:445
	_onDropItem	@	foundry.js:75007

I am on V12 of Foundry, if that has anything to do with this?

Thank you for reading, and perhaps taking the time to answer.

[Dangermouse]

Thanks for the kind words and reporting this.   Currently this implementation doesn't support taking stuff directly from the Compendium.  If you import the compendium in to the world then it should (fingers crossed) work.

I will, at some stage, change this so you can use stuff directly from the Compendia - but there's a lot of things I need to think about and investigate.

Let me know if you can drag n drop from the game world items.

Cheers

Simon
 

[Barak Shathur]

I want to echo everyone else and say thanks for an excellent sheet, it looks exceedingly promising! I too am having a problem with adding weapons to the sheet though. I seem to be able to add a two weapons and then no more. When I tried deleting them, I subsequently couldn't add them, or anything else. Starting up a new sheet lets me add two weapons, some armour, and nothing else. 

EDIT: It seems that once I add skills (either a single skill, or the whole Basic skill package) to a character sheet, I am no longer able to add any weapons to it.

Edited October 4 by Barak Shathur

[Dangermouse]

6 hours ago, Barak Shathur said:

I want to echo everyone else and say thanks for an excellent sheet, it looks exceedingly promising! I too am having a problem with adding weapons to the sheet though. I seem to be able to add a two weapons and then no more. When I tried deleting them, I subsequently couldn't add them, or anything else. Starting up a new sheet lets me add two weapons, some armour, and nothing else. 

EDIT: It seems that once I add skills (either a single skill, or the whole Basic skill package) to a character sheet, I am no longer able to add any weapons to it.

Thanks for calling this out - quick question and I will try to look at this over the weekend.  Do you have the skills and weapons imported from the Compendium to the game world (i.e. you can see them under the items tab)?

Cheers

Simon

[Barak Shathur]

3 hours ago, Dangermouse said:

Thanks for calling this out - quick question and I will try to look at this over the weekend.  Do you have the skills and weapons imported from the Compendium to the game world (i.e. you can see them under the items tab)?

Cheers

Simon

Yes. Thanks!
 

Edited October 4 by Barak Shathur

[FantasticSkoph]

On 10/3/2024 at 7:46 AM, Dangermouse said:

Thanks for the kind words and reporting this.   Currently this implementation doesn't support taking stuff directly from the Compendium.  If you import the compendium in to the world then it should (fingers crossed) work.

I will, at some stage, change this so you can use stuff directly from the Compendia - but there's a lot of things I need to think about and investigate.

Let me know if you can drag n drop from the game world items.

Cheers

Simon
 

Thank you for your reply. Yes, I have tried importing the weapon into the game's item list, and from there import it into the character sheet, but it shows me an error.

"Please assign a combat skill to this weapon before adding it to a character."

When I go into the weapon's details to select a "skill option", the list is blank, and even transparent. I have also tried creating a new weapon from scratch but yet again I can't select a skill option, and thus cannot add it to the character sheet. I have the same error message if I try that.

[Dangermouse]

@FantasticSkoph @Barak Shathur

Thanks both - it's been a while since I looked at the code so apologies it's taken me a bit to dig in to it.

When you imported the compendium did you tick the "Keep Document IDs"?

When I create a new world and tick Keep Document IDs when importing the compendia - I can add skills and weapons without a problem
When I create a new world and don't tick Keep Documents IDs when importing the compendia I get the error message you saw.

actor-itemDrop.mjs:56 Uncaught (in promise) TypeError: Cannot read properties of undefined (reading 'name')
    at BRPactorItemDrop._BRPonDropItemCreate (actor-itemDrop.mjs:56:61)
    at BRPCharacterSheet._onDropItemCreate (character.mjs:445:48)
    at BRPCharacterSheet._onDropItem (foundry.js:75007:17)


Every weapon has two skills (which can be None) - this is recorded in the items as a document ID.  For example Rapier/system/skill1 = "Y7iB3C7jEWskXHja".    The code then retrieves that item from the game world and get's its name "Rapier" and compares it to the skill names on the actor sheet.  This is the line of code you're getting the error message on.

So in the console can you enter 

game.items.get("ATwEZM9xwgP5uImS")

You should get the "Rapier" item.  Expand that and then expand "system" and see what's in "Skill1"

Copy the contents of the Skill1 and then paste that in the console as where PASTE HERE = what you copied

game.items.get("PASTE HERE")

That should then pull back the sword skill


Let me know how that goes - in the meantime I will add a warning message on screen for the next release.


Longer term I was looking to implement something along the lines of the Call of Cthulhu IDs to avoid the Document ID issue - I'll make a separate post asking for feedback on this idea (and going in to it a bit more).

Cheers

Simon

[Dangermouse]

On 9/30/2024 at 2:26 PM, BlackLaird said:

 I am wondering if I can put in a feature request for Personality Traits when you next pick this one up. If this is possible, my personal preference would be for user defined trait pairs rather than pre-set (as per Pendragon for example). 

Quick question (yes I am actually working on this) - when you say user defined do you want players to be able to edit the "opposed" name (assuming they're on a character sheet) or just the GM?

[Barak Shathur]

On 10/4/2024 at 12:31 AM, Barak Shathur said:

I want to echo everyone else and say thanks for an excellent sheet, it looks exceedingly promising! I too am having a problem with adding weapons to the sheet though. I seem to be able to add a two weapons and then no more. When I tried deleting them, I subsequently couldn't add them, or anything else. Starting up a new sheet lets me add two weapons, some armour, and nothing else. 

EDIT: It seems that once I add skills (either a single skill, or the whole Basic skill package) to a character sheet, I am no longer able to add any weapons to it.

I figured out the problem. When importing the compendiums, I hadn't checked the 'keep Document ID' box. My bad.

Follow up question: will it in the future be possible to import individual folders from a compendium, say "Historic Melee Weapons"? As it is now, I have to import the whole compendium and then delete what I don't need. Just an ease-of-use issue, nothing critical.

[Dangermouse]

12 minutes ago, Barak Shathur said:

I figured out the problem. When importing the compendiums, I hadn't checked the 'keep Document ID' box. My bad.

Follow up question: will it in the future be possible to import individual folders from a compendium, say "Historic Melee Weapons"? As it is now, I have to import the whole compendium and then delete what I don't need. Just an ease-of-use issue, nothing critical.

What I was thinking of doing was implementing the Call of Cthulhu ID approach - does away with the need for Document IDs and so you could then not have to import stuff at all.  The full CoC ID also has "eras" so you could set certain weapons to certain eras and the game uses only those relevant weapons etc.  This is a big chunk of work.

I can look to separate weapons out to different compendium if that helps in the short term.  I have also been thinking about removing the compendia from the main game and providing them (free) as modules - and could split them out by era (Primitive, Ancient, Modern etc) so you just pick the modules you want.

Will try and work something up but it'll be a while (just finishing the next release which may be out today, otherwise late next week - holiday gets in the way).

Please nudge me if you don't hear anything on progress but also let me know what you think works best.

Cheers

[Barak Shathur]

1 hour ago, Dangermouse said:

What I was thinking of doing was implementing the Call of Cthulhu ID approach - does away with the need for Document IDs and so you could then not have to import stuff at all.  The full CoC ID also has "eras" so you could set certain weapons to certain eras and the game uses only those relevant weapons etc.  This is a big chunk of work.

I can look to separate weapons out to different compendium if that helps in the short term.  I have also been thinking about removing the compendia from the main game and providing them (free) as modules - and could split them out by era (Primitive, Ancient, Modern etc) so you just pick the modules you want.

Will try and work something up but it'll be a while (just finishing the next release which may be out today, otherwise late next week - holiday gets in the way).

Please nudge me if you don't hear anything on progress but also let me know what you think works best.

Cheers

Whatever is less work for you! And less clicking for me 🙂

EDIT:I had some problems importing weapon skills, for some reason not all weapon categories were imported but reimporting solved it!

EDIT 2: I had some issue with Encumbrance/Fatigue not functioning correctly, but it does now so nevermind.

Edited October 9 by Barak Shathur

[Dangermouse]

3 hours ago, Barak Shathur said:

Whatever is less work for you! And less clicking for me 🙂

EDIT:I had some problems importing weapon skills, for some reason not all weapon categories were imported but reimporting solved it!

EDIT 2: I had some issue with Encumbrance/Fatigue not functioning correctly, but it does now so nevermind.

Thanks for the update.  Just packaging up a new release which will hopefully go out shortly (famous last words)

[Dangermouse]

Just released BRP v12.1.23 - hopefully hasnt broken anything as I'm now away for a few days

12.1.23

Skill categories on the actor sheet get to use the full width of the skill list column to prevent wrap around issues

Add Supernatural as a skill category and a game setting. If unticked then any skills with Supernatural won't be shown on the character sheet

Add Social as a skill category and a game setting. If unticked then any skills with Social won't be shown on the character sheet

Personality Traits have been added. You can roll on the Personality Trait or the Opposed Trait and do XP improvements as well.

You can drag Personality Traits to the hotbar for a macro. Using the ALT key when clicking on it triggers the Opposed roll.

Added macro roll functionality for Passions (previously only displayed the item sheet).

All item Descriptions and GM Descriptions are now rich text.

Background, backstory and biography are now rich text.

NPC sheets now have Passions, Allegiance and Personality Traits. Unless you have an item on the NPC or the sheet is unlocked you won't see the sections (to save space) - you can drag and drop an item on and it will appear. This has been added for Powers as well.

[FantasticSkoph]

On 10/5/2024 at 9:33 AM, Dangermouse said:

When you imported the compendium did you tick the "Keep Document IDs"?

It doesn't seem like that's an option that's available to me. I don't know if it's native to Foundry V12, but when I right click on an item and click on "Import Entry", it just does it and opens the item's details. I don't have any pop-up window asking me to tick the "keep documents IDs" option.

I have all my other modules deactivated aside from the BRP system. If there's another way to do it, I'll gladly take it. Or I can download Foundry V11 to try it out.

[Barak Shathur]

13 hours ago, FantasticSkoph said:

It doesn't seem like that's an option that's available to me. I don't know if it's native to Foundry V12, but when I right click on an item and click on "Import Entry", it just does it and opens the item's details. I don't have any pop-up window asking me to tick the "keep documents IDs" option.

I have all my other modules deactivated aside from the BRP system. If there's another way to do it, I'll gladly take it. Or I can download Foundry V11 to try it out.

The 'Keep Document ID' option only appears when importing a whole folder, not individual items.

[Barak Shathur]

I am wondering how Encumbrance will be implemented. Right now it only seems to relate to Fatigue points.

[Dangermouse]

I will have to sit down and read the rules and options to figure it out. 
 

is ENC/Fatigue a high priority request for people?  Shout now. 

[Barak Shathur]

On 10/10/2024 at 11:09 AM, Dangermouse said:

I will have to sit down and read the rules and options to figure it out. 
 

Good luck. I can't make heads or tails of it 

 

I'd say you can keep it the way it is now, with ENC simply reducing Fatigue, if you remove the 'wear' function of armour. The Fatigue Point system doesn't make sense if armour worn is disregarded.

[FantasticSkoph]

On 10/10/2024 at 9:04 AM, Barak Shathur said:

The 'Keep Document ID' option only appears when importing a whole folder, not individual items.

Okay, that was the information I was missing, but now it seems to be working much better. I can now pick a skill and add weapons to my sheets. Thank you both Dangermouse and Barak Shathur for the help!